Skip to content

Update to Go 1.24.8 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
embik wants to merge 8 commits into from
Closed

Update to Go 1.24.8 #104

embik wants to merge 8 commits into from

Conversation

@embik
Copy link
Member

@embik embik commented Oct 8, 2025

Summary

Updates our Go version to the latest 1.24 release.

What Type of PR Is This?

/kind cleanup

Related Issue(s)

Towards kcp-dev/infra#136

Release Notes

kcp-operator is built with Go 1.24.8

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Oct 8, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Oct 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from embik. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 8, 2025
@embik embik mentioned this pull request Oct 8, 2025
Merged
embik added a commit to embik/kcp-infra that referenced this pull request Oct 8, 2025
@embik
Run kcp-operator periodic with Go 1.24.8
2512680 
Aligns with kcp-dev/kcp-operator#104.

On-behalf-of: SAP <marvin.beckers@sap.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik embik mentioned this pull request Oct 8, 2025
Merged
@embik
Copy link
Member Author

embik commented Oct 9, 2025

/retest

@embik embik mentioned this pull request Oct 9, 2025
Merged
@kcp-ci-bot kcp-ci-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2025
embik added 2 commits October 10, 2025 10:57
@embik
Update to Go 1.24.8
1c6bcbc 
On-behalf-of: SAP <marvin.beckers@sap.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Use new build image with updated docker and kind
fc55c51 
On-behalf-of: SAP <marvin.beckers@sap.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@kcp-ci-bot kcp-ci-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2025
@embik embik marked this pull request as draft October 10, 2025 09:04
@kcp-ci-bot kcp-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2025
@embik
Copy link
Member Author

embik commented Oct 10, 2025

/test pull-kcp-operator-test-e2e

@embik
Copy link
Member Author

embik commented Oct 10, 2025

/test pull-kcp-operator-test-e2e

@embik
Copy link
Member Author

embik commented Oct 10, 2025

/test pull-kcp-operator-test-e2e

@embik
Copy link
Member Author

embik commented Oct 10, 2025

/test pull-kcp-operator-test-e2e

@embik
Use latest kind node image
280cfce 
On-behalf-of: SAP <marvin.beckers@sap.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Copy link
Member Author

embik commented Oct 10, 2025

/test pull-kcp-operator-test-e2e

@kcp-ci-bot kcp-ci-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 10, 2025
@embik
Copy link
Member Author

embik commented Oct 10, 2025

/test pull-kcp-operator-test-e2e

@embik
Build both images
39edf06 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Copy link
Member Author

embik commented Oct 10, 2025

/test pull-kcp-operator-test-e2e

1 similar comment
@embik
Copy link
Member Author

embik commented Oct 10, 2025

/test pull-kcp-operator-test-e2e

@embik
More testing
889da78 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Copy link
Member Author

embik commented Oct 10, 2025

/test pull-kcp-operator-test-e2e

@kcp-ci-bot kcp-ci-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2025
@embik
Copy link
Member Author

embik commented Oct 10, 2025

/test pull-kcp-operator-test-e2e

@embik
Copy link
Member Author

embik commented Oct 10, 2025

/test pull-kcp-operator-test-e2e

@embik
Further downgrade
ffedb10 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Copy link
Member Author

embik commented Oct 10, 2025

/test pull-kcp-operator-test-e2e

@kcp-ci-bot kcp-ci-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 10, 2025
@embik
Update again
47a8751 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Copy link
Member Author

embik commented Oct 10, 2025

/test pull-kcp-operator-test-e2e

@embik
Try newest kind/node image
b3cee29 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Copy link
Member Author

embik commented Oct 10, 2025

/test pull-kcp-operator-test-e2e

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Oct 10, 2025

@embik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-operator-test-e2e-canary e62fd54 link false /test pull-kcp-operator-test-e2e-canary
pull-kcp-operator-test-e2e b3cee29 link true /test pull-kcp-operator-test-e2e

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@embik embik closed this Oct 10, 2025
@embik embik mentioned this pull request Oct 10, 2025
Merged
embik added a commit to embik/kcp-infra that referenced this pull request Oct 14, 2025
@embik
Run kcp-operator periodic with Go 1.24.8
330b048 
Aligns with kcp-dev/kcp-operator#104.

On-behalf-of: SAP <marvin.beckers@sap.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
embik added a commit to embik/kcp-infra that referenced this pull request Oct 21, 2025
@embik
Run kcp-operator periodic with Go 1.24.9
bbb055e 
Aligns with kcp-dev/kcp-operator#104.

On-behalf-of: SAP <marvin.beckers@sap.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@embik @kcp-ci-bot