Skip to content

Replace … with ... #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kcp-ci-bot merged 1 commit into from
Oct 9, 2025
Merged

Replace … with ... #106

kcp-ci-bot merged 1 commit into from
Oct 9, 2025
+47 −47

Conversation

@mjudeikis
Copy link
Contributor

@mjudeikis mjudeikis commented Oct 9, 2025 •
edited
Loading

Summary

What Type of PR Is This?

… mac does not quite like these. This is an unnecessary inconvenience for anybody trying to run scripts and getting these errors. It just is not worth the effort.

~/go/src/github.com/kcp-dev/kcp-operator mjudeikis/update.external.shard.base.url* ❯ make test-e2e-with-kind                                                                                                                                                                                                                                                                                                                                                                                                                                                                   10:38:21
Logs are stored in .e2e-e2e/.
hack/run-e2e-tests.sh: line 33: KIND_CLUSTER_NAME�: unbound variable
make: *** [test-e2e-with-kind] Error 1

/kind cleanup

Related Issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 9, 2025
@mjudeikis mjudeikis changed the title Replace … with .... Replace … with ... Oct 9, 2025
@mjudeikis mjudeikis added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 9, 2025
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Oct 9, 2025
@mjudeikis
Copy link
Contributor Author

mjudeikis commented Oct 9, 2025

/retest

1 similar comment
@mjudeikis
Copy link
Contributor Author

mjudeikis commented Oct 9, 2025

/retest

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Oct 9, 2025

@mjudeikis: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-operator-test-e2e-canary 36d9111 link false /test pull-kcp-operator-test-e2e-canary

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sttts
Copy link
Member

sttts commented Oct 9, 2025

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Oct 9, 2025

LGTM label has been added.

Git tree hash: 2046a15c66af6b41e556c299d0d8320502987ae6

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2025
@kcp-ci-bot kcp-ci-bot merged commit 44d4a7b into kcp-dev:main Oct 9, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sttts sttts

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mjudeikis @kcp-ci-bot @sttts