Skip to content

added an empty line before the Deprecated tag#223

Merged
kcp-ci-bot merged 1 commit into
kcp-dev:mainfrom
olamilekan000:add-empty-line-after-deprecate-tag
Apr 21, 2026
Merged

added an empty line before the Deprecated tag#223
kcp-ci-bot merged 1 commit into
kcp-dev:mainfrom
olamilekan000:add-empty-line-after-deprecate-tag

Conversation

@olamilekan000

@olamilekan000 olamilekan000 commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Summary

change added an empty line before the Deprecated tag in sdk/apis/operator/v1alpha1/common.go

What Type of PR Is This?

/kind deprecation

Related Issue(s)

Fixes #

Release Notes

Added an empty line before the Deprecated tag

@kcp-ci-bot kcp-ci-bot added kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Apr 21, 2026
@kcp-ci-bot

Copy link
Copy Markdown
Contributor

Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kcp-ci-bot kcp-ci-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 21, 2026
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 21, 2026
@olamilekan000 olamilekan000 force-pushed the add-empty-line-after-deprecate-tag branch from 60b9b16 to 959abcd Compare April 21, 2026 09:40
@olamilekan000 olamilekan000 force-pushed the add-empty-line-after-deprecate-tag branch from 959abcd to e8ae01a Compare April 21, 2026 09:53
@kcp-ci-bot kcp-ci-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2026
@xrstf xrstf changed the title added an empty line efore the Deprecated tag added an empty line before the Deprecated tag Apr 21, 2026

@xrstf xrstf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2026
@kcp-ci-bot

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: da09b8bd333bdd1dd43f4de2a36795ed4b63e39e

@kcp-ci-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2026
@kcp-ci-bot kcp-ci-bot merged commit cc23164 into kcp-dev:main Apr 21, 2026
13 checks passed
ghdrope pushed a commit to ghdrope/forked-kcp-operator that referenced this pull request Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants