Skip to content

Conversation

@cupakob
Copy link
Contributor

@cupakob cupakob commented Oct 29, 2024

In this functions the returned errors are always nil. They can be removed and this makes the code a little bit simpler.

Summary

Related issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2024
@kcp-ci-bot
Copy link
Contributor

Hi @cupakob. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 29, 2024
@mjudeikis
Copy link
Contributor

/ok-to-test

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 1, 2024
@stevekuznetsov
Copy link
Contributor

pkg/cache/client/context.go:1: : # github.com/kcp-dev/kcp/pkg/cache/client [github.com/kcp-dev/kcp/pkg/cache/client.test]
pkg/cache/client/round_tripper_test.go:72:19: assignment mismatch: 2 variables but generatePath returns 1 value (typecheck) 

In this functions the returned errors are always nil. They can be
removed and this makes the code a little bit simpler.

Signed-off-by: Atanas Alexandrov <sirakov@gmail.com>
@cupakob cupakob force-pushed the small-code-improvements branch from 3b5d943 to dda62e4 Compare November 2, 2024 06:36
@cupakob
Copy link
Contributor Author

cupakob commented Nov 2, 2024

pkg/cache/client/context.go:1: : # github.com/kcp-dev/kcp/pkg/cache/client [github.com/kcp-dev/kcp/pkg/cache/client.test]
pkg/cache/client/round_tripper_test.go:72:19: assignment mismatch: 2 variables but generatePath returns 1 value (typecheck) 

sorry, I did not checked the test results, fixed now

@stevekuznetsov
Copy link
Contributor

/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: a41e0dced8088f3a2eddd5c903ac457d6684f3c0

Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

thanks!

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2024
@embik
Copy link
Member

embik commented Nov 8, 2024

/retest

looks like a flake.

@kcp-ci-bot kcp-ci-bot merged commit f8fe716 into kcp-dev:main Nov 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants