-
Notifications
You must be signed in to change notification settings - Fork 423
🌱 Remove unused return value (error) #3193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @cupakob. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
In this functions the returned errors are always nil. They can be removed and this makes the code a little bit simpler. Signed-off-by: Atanas Alexandrov <sirakov@gmail.com>
3b5d943 to
dda62e4
Compare
sorry, I did not checked the test results, fixed now |
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: a41e0dced8088f3a2eddd5c903ac457d6684f3c0 |
palnabarun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
embik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
thanks!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest looks like a flake. |
In this functions the returned errors are always nil. They can be removed and this makes the code a little bit simpler.
Summary
Related issue(s)
Fixes #
Release Notes