Skip to content

Conversation

@mjudeikis
Copy link
Contributor

Summary

What Type of PR Is This?

/kind feature

Enable namepspace lifecycle plugin and add kube-system namespace

~/go/src/github.com/kcp-dev/kcp kube.system.ns* ❯ k create ns bob                                                             15:56:46
Error from server (AlreadyExists): namespaces "bob" already exists
~/go/src/github.com/kcp-dev/kcp kube.system.ns* ❯ k delete ns bob                                                             15:56:50
namespace "bob" deleted

~/go/src/github.com/kcp-dev/kcp kube.system.ns* 5s ❯                                                                          15:56:59
~/go/src/github.com/kcp-dev/kcp kube.system.ns* ❯ k get ns                                                                    15:56:59
NAME          STATUS   AGE
default       Active   9m15s
kube-system   Active   9m15s
~/go/src/github.com/kcp-dev/kcp kube.system.ns* ❯ k delete ns --all                                                           15:57:01
Error from server (Forbidden): namespaces "default" is forbidden: this namespace may not be deleted
Error from server (Forbidden): namespaces "kube-system" is forbidden: this namespace may not be deleted

Related Issue(s)

Fixes #

Release Notes

Add kubernetes lifecycle plugin & add kube-system namespace

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 19, 2025
@mjudeikis
Copy link
Contributor Author

/retest

1 similar comment
@mjudeikis
Copy link
Contributor Author

/retest

@kcp-ci-bot kcp-ci-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 22, 2025
@mjudeikis
Copy link
Contributor Author

/retest

Copy link
Member

@ntnn ntnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 92d2c4e79f2431da7ec540441deb571fa565bbc7

@mjudeikis
Copy link
Contributor Author

#3770
/retest

@mjudeikis mjudeikis added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: ntnn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot merged commit fa243f8 into kcp-dev:main Dec 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants