Try prevent flaking by placing org and ws on same shard#3931
Open
ntnn wants to merge 1 commit intokcp-dev:mainfrom
Open
Try prevent flaking by placing org and ws on same shard#3931ntnn wants to merge 1 commit intokcp-dev:mainfrom
ntnn wants to merge 1 commit intokcp-dev:mainfrom
Conversation
ntnn
added
the
tide/merge-method-squash
kcp-ci-bot
added
release-note-none
gman0
reviewed
Mar 20, 2026
| name: "create and clean workspace", | ||
| work: func(ctx context.Context, t *testing.T, server runningServer) { | ||
| orgPath, _ := kcptesting.NewWorkspaceFixture(t, server, core.RootCluster.Path(), kcptesting.WithType(core.RootCluster.Path(), "organization")) | ||
| orgPath, _ := kcptesting.NewWorkspaceFixture(t, server, core.RootCluster.Path(), kcptesting.WithRootShard(), kcptesting.WithType(core.RootCluster.Path(), "organization")) |
Contributor
There was a problem hiding this comment.
Maybe add a comment for the rationale behind this change? Something like in the PR's description would suffice.
Contributor
|
/lgtm |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 2ffbdfa2ccda9bc95c195cd13f74c1a26313b948 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
`create and clean workspace` has been flaking due to eventually timeouts, while the other subtest hasn't flaked. The other subtest places the org and workspace on the root shard explicitly, this test didn't. My guess is that the cross-shard operation (plus all the other tests) is just enough delay for the test to fail every now and then. It's worth a try - at worst the two tests will have a similar setup. Also added a note explaining the use of the .WithRootShard to the second subtest with a note on future refactoring. Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com> Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
ntnn
force-pushed
the
kcp-test-workspace-deletion_create-and-clean-workspace
branch
from
b269ee9 to
b8abff3
Compare
Contributor
|
New changes are detected. LGTM label has been removed. |
kcp-ci-bot
added
size/S
Member
Author
|
@gman0 I like the suggestion; I also put in a comment in the second test. I think we could refactor both at some point to not require pinning the shard in either. |
Member
Author
|
/retest The failures are all related to the APIBindings not being ready yet, see: #3934 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create and clean workspacehas been flaking due to eventually timeouts, while the other subtest hasn't flaked. The other subtest places the org and workspace on the root shard explicitly, this test didn't.My guess is that the cross-shard operation (plus all the other tests) is just enough delay for the test to fail every now and then. It's worth a try - at worst the two tests will have a similar setup.
What Type of PR Is This?
/kind flake
Related Issue(s)
Fixes #
Release Notes