Skip to content

Reduce quota metrics#4050

Merged
kcp-ci-bot merged 1 commit into
kcp-dev:mainfrom
mjudeikis:metrics.cardinality.reduce
Apr 21, 2026
Merged

Reduce quota metrics#4050
kcp-ci-bot merged 1 commit into
kcp-dev:mainfrom
mjudeikis:metrics.cardinality.reduce

Conversation

@mjudeikis
Copy link
Copy Markdown
Contributor

@mjudeikis mjudeikis commented Apr 20, 2026

Summary

This is short stop gap to reduce GC metrics cardinality.

What Type of PR Is This?

/kind chore

Related Issue(s)

Fixes #

Release Notes

BREAKING: Rename label on quota queue label to reduce cardinality:
rename workqueue_adds_total{name="quota-<logical-cluster-name>} to workqueue_adds_total{name="quota"}

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Apr 20, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mjudeikis
Copy link
Copy Markdown
Contributor Author

/test all

@kcp-ci-bot kcp-ci-bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 20, 2026
@mjudeikis mjudeikis marked this pull request as ready for review April 20, 2026 11:59
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2026
@mjudeikis mjudeikis added the kind/chore Categorizes issue or PR as related to maintenance and other usually non-code changes. label Apr 20, 2026
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Apr 20, 2026
@ntnn
Copy link
Copy Markdown
Member

ntnn commented Apr 20, 2026

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: fe07922c678eec48309b942762cd17f8d33853e3

@kcp-ci-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ntnn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2026
@ntnn ntnn added this to tbd Apr 20, 2026
@ntnn ntnn moved this to Reviewing in tbd Apr 20, 2026
@mjudeikis
Copy link
Copy Markdown
Contributor Author

/retest

@kcp-ci-bot kcp-ci-bot merged commit 0e6afb8 into kcp-dev:main Apr 21, 2026
14 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewing to Done in tbd Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/chore Categorizes issue or PR as related to maintenance and other usually non-code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants