Skip to content

Fix noisy logs#4098

Merged
kcp-ci-bot merged 3 commits into
kcp-dev:mainfrom
mjudeikis:patch.fix.lc
May 14, 2026
Merged

Fix noisy logs#4098
kcp-ci-bot merged 3 commits into
kcp-dev:mainfrom
mjudeikis:patch.fix.lc

Conversation

@mjudeikis
Copy link
Copy Markdown
Contributor

@mjudeikis mjudeikis commented May 5, 2026

Summary

Fix noise from these:

E0505 11:53:36.017686    1919 apibinder_initializer_controller.go:291] "Unhandled Error" err="kcp-apibinder-initializer: failed to sync \"i0wh7p9b1xi5w2t8|cluster\", err: failed to patch *v1alpha1.LogicalCluster cluster: LogicalCluster.tenancy.kcp.io \"cluster\" is invalid: status.initializers: Invalid value: [\"system:apibindings\"]: only removing the \"system:apibindings\" initializer is supported" logger="UnhandledError"

What Type of PR Is This?

/kind chore

Related Issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented May 5, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/chore Categorizes issue or PR as related to maintenance and other usually non-code changes. dco-signoff: yes Indicates the PR's author has signed the DCO. labels May 5, 2026
@mjudeikis mjudeikis marked this pull request as ready for review May 5, 2026 09:57
@kcp-ci-bot kcp-ci-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 5, 2026
SimonTheLeg
SimonTheLeg suggested changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@SimonTheLeg SimonTheLeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can make the same change to terminatingworkspaces forwarding.go as well + a tiny pet-peeve nit :)

Comment thread pkg/virtual/initializingworkspaces/builder/forwarding.go Outdated
Comment on lines +227 to +229
for _, item := range current {
if item == string(initializer) {
return invalidUpdateErr
Copy link
Copy Markdown
Member

@SimonTheLeg SimonTheLeg May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think this one can just be slices.Contains

@kcp-ci-bot kcp-ci-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2026
ntnn
ntnn approved these changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ntnn ntnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented May 13, 2026

LGTM label has been added.

DetailsGit tree hash: c662677f37c3298044d7abe76f9c52e9754113fc

@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ntnn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2026
@ntnn ntnn added this to tbd May 13, 2026
@ntnn ntnn moved this to Reviewing in tbd May 13, 2026
@ntnn
Copy link
Copy Markdown
Member

ntnn commented May 13, 2026

/retest

1 similar comment
@mjudeikis
Copy link
Copy Markdown
Contributor Author

mjudeikis commented May 13, 2026

/retest

@ntnn
Copy link
Copy Markdown
Member

ntnn commented May 13, 2026

/retest

  0     0    0     0    0     0      0      0 --:--:--  0:00:08 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:09 --:--:--     0curl: (6) Could not resolve host: github.com
make: *** [Makefile:149: /home/prow/go/src/github.com/kcp-dev/kcp/hack/tools/prometheus-3.11.0] Error 6

@mjudeikis
Copy link
Copy Markdown
Contributor Author

mjudeikis commented May 14, 2026

/retest

@kcp-ci-bot kcp-ci-bot merged commit 635ae3e into kcp-dev:main May 14, 2026
14 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewing to Done in tbd May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntnn ntnn ntnn approved these changes

+1 more reviewer

@SimonTheLeg SimonTheLeg SimonTheLeg requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ntnn ntnn

@SimonTheLeg SimonTheLeg

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/chore Categorizes issue or PR as related to maintenance and other usually non-code changes. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mjudeikis @kcp-ci-bot @ntnn @SimonTheLeg