fix: WorkspaceType admission rejecting forward-referenced APIExports#4149
fix: WorkspaceType admission rejecting forward-referenced APIExports#4149pen-pal wants to merge 1 commit into
Conversation
The bind-permission gate added in 429ccf7 returned a "no permission to bind to export" forbidden whenever the referenced APIExport could not be resolved, blocking even admins from creating a WorkspaceType ahead of its APIExports. Treat NotFound as a skip so the declarative ordering flow that worked before 0.31.2 keeps working; an existing APIExport still triggers the SAR. Fixes kcp-dev#4145 Signed-off-by: pen-pal <unameme@proton.me>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @pen-pal. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
Fixes a regression in 0.31.2 where creating a
WorkspaceTypereferencing an APIExport that doesn't exist yet is rejected withno permission to bind to export ..., even for admins.The bind-permission check (added in #4082) treats a NotFound on the APIExport lookup the same as a permission denial. This breaks the common flow of creating a
WorkspaceTypebefore its APIExports.Now: if the APIExport isn't found, skip the SAR for that entry. The check still runs whenever the APIExport exists.
What Type of PR Is This?
/kind bug
/kind regression
Related Issue(s)
Fixes #4145
Release Notes