forward current cluster context in TokenReviews #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On-behalf-of: @SAP christoph.mewes@sap.com
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
With the introduction of per-workspace authentication in kcp, the handler for TokenReviews needs to ensure that the current cluster context (the cluster in which the TokenReview is created) is included in the fake request, so that the authenticator can find the auth configuration.
This fix alone will not make TokenReviews work in kcp (with the WorkspaceAuthentication feature gate enabled). kcp still needs to be patched to provide a suitable authenticator to the storage provider which does not rely on other handlers in the handler mux chain to provide stuff to it. PR for that is in the works.
Which issue(s) this PR is related to:
kcp-dev/kcp#3614
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: