Skip to content

forward current cluster context in TokenReviews #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
Merged

forward current cluster context in TokenReviews #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/registry/authentication/tokenreview/storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,15 @@ func (r *REST) Create(ctx context.Context, obj runtime.Object, createValidation
fakeReq := &http.Request{Header: http.Header{}}
fakeReq.Header.Add("Authorization", "Bearer "+tokenReview.Spec.Token)

// kcp
cluster := genericapirequest.ClusterFrom(ctx)
if cluster == nil {
return nil, apierrors.NewBadRequest("cannot handle TokenReviews wihout a cluster in the context")
}
// For the per-workspace-authentication in kcp to work, the authenticator needs access to the cluster name.
fakeReq = fakeReq.WithContext(genericapirequest.WithCluster(fakeReq.Context(), *cluster))
// end kcp

auds := tokenReview.Spec.Audiences
if len(auds) == 0 {
auds = r.apiAudiences
Expand Down