Refactor Media Foundation initialization for clarity and async handling#56
Merged
Conversation
Renamed and simplified Media Foundation initialization methods for better clarity. Removed redundant `isInitialized` flag and introduced `readyForPlayback` check to ensure readiness for playback. Improved code structure and comments to streamline initialization and enhance maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refactors the initialization logic for
WindowsVideoPlayerState, focusing on improved clarity, maintainability, and async handling. Fix #39Changes
isInitializedflag with areadyForPlaybackcheck.CompletableDeferredfor cleaner and more reliable async player initialization.Notes
The changes streamline the initialization process, enhance reliability, and improve error handling. This ensures the player's readiness for playback and simplifies asynchronous state management.