refactor(dsl): move installationPath to macOS-only#12
Merged
kdroidFilter merged 1 commit intomainfrom Feb 17, 2026
Merged
Conversation
… path installationPath was defined on AbstractPlatformSettings (shared base), exposing it in the DSL for Windows and Linux where it is never used. Move it to AbstractMacOSPlatformSettings. Also fix build-universal.sh productbuild call that hardcoded /Applications instead of using $INSTALL_LOCATION from metadata JSON.
kdroidFilter
force-pushed
the
refactor/move-installationPath-macos-only
branch
from
95860c9 to
21a26b9
Compare
kdroidFilter
added a commit
that referenced
this pull request
Apr 19, 2026
X11 ICCCM compliance (#4/#5): - SetSelectionOwner now uses real server timestamp via PropertyNotify probe, not XCB_CURRENT_TIME (violates ICCCM §2.1). Added get_server_timestamp_locked() which fires a zero-byte ChangeProperty to trigger timestamp event. - TIMESTAMP replies now return g_own_ts (real value) instead of truncated 0. - Verified: xclip -o -t TIMESTAMP returns non-zero after our clipboard write. INCR cleanup (#3): - On INCR read timeout, delete property to unblock sender waiting for PropertyNotify=Delete (ICCCM compliant termination). Process lifecycle (#7): - Wayland: runCaptureBytes, runSilently, writeBytes now escalate to destroyForcibly() if SIGTERM doesn't terminate after 500ms grace. AccessBehavior mapping (#12): - Kotlin: explicit when() mapping (0→AlwaysAllow, 1→AskEveryTime, 2→AlwaysDeny) instead of ordinal/entries.getOrNull (fragile with future macOS versions). - ObjC: validate input 0..2 on set; return -1 if get() returns out-of-range. Documentation & robustness (#13, #1): - Clipboard.watch() doc: clarify poll interval is always honored; source of counter differs by backend (Mach IPC / XFixes / wl-paste). - Re-check isActive after slow availableFormats() to avoid emitting to cancelled flow. Added X11TimestampSmokeTest to verify real timestamps are used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
installationPathfromAbstractPlatformSettings(shared) toAbstractMacOSPlatformSettings— it was never used by Windows or Linux targetsproductbuildinbuild-universal.shthat hardcoded/Applicationsinstead of using$INSTALL_LOCATIONfrom metadata JSONinstallationPathfrom Linux DSL table, improve description in macOS tableTest plan
preMergepasses with JDK 21installationPathcorrectly viadistributions.macOS.installationPath