Remove acronymizer.db dependency and fix acronym indexing#27
Merged
kdroidFilter merged 1 commit intomasterfrom Jan 13, 2026
Merged
Remove acronymizer.db dependency and fix acronym indexing#27kdroidFilter merged 1 commit intomasterfrom
kdroidFilter merged 1 commit intomasterfrom
Conversation
- Fix BuildLuceneIndex to sanitize acronyms before indexing This ensures acronyms like "רמב״ם" are normalized to "רמבמ" in the index, fixing search issues where complete acronyms returned no results - Remove acronymizer.db from packaging pipeline All acronym data is already in seforim.db (book_acronym table), so no need to package a separate database. Saves ~6 MB in bundle size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
BuildLuceneIndex.kt
sanitizeAcronymTerm()to acronyms before indexingPackageArtifacts.kt
Benefits
Testing