fix: skip Otzaria links for books imported from Sefaria#28
Merged
kdroidFilter merged 1 commit intomasterfrom Jan 13, 2026
Merged
fix: skip Otzaria links for books imported from Sefaria#28kdroidFilter merged 1 commit intomasterfrom
kdroidFilter merged 1 commit intomasterfrom
Conversation
Otzaria link files use matching line indices for source and target books, but this doesn't account for different header structures between books (e.g., Genesis has 2 header lines while Onkelos has 3). This caused ~32,000 duplicate/incorrect TARGUM links where verse N of a source book was incorrectly linked to verse N-1 of the targum. Fix: Track books imported from Sefaria sources and skip Otzaria link generation for these books, since Sefaria already provides accurate verse-to-verse mappings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problème
Les fichiers de liens Otzaria utilisent des indices de ligne identiques pour les livres source et cible, mais cela ne tient pas compte des structures d'en-tête différentes entre les livres.
Par exemple :
Cela a causé ~32 000 liens TARGUM en double/incorrects où le verset N d'un livre source était incorrectement lié au verset N-1 du targum.
Solution
sefariaBookIdsqui identifie les livres importés depuis SefariaprocessLinksForBook()etprocessLinkFile()Changements
Generator.kt: Ajout de la logique de skip pour les livres SefariaTest
Pour corriger une base de données existante, régénérer les liens avec :