fix: use base_text_order for commentary book ordering#43
Merged
kdroidFilter merged 1 commit intodevfrom Jan 24, 2026
Merged
Conversation
Sefaria's table_of_contents.json doesn't provide an 'order' field for commentary books. Instead, it provides 'base_text_order' which indicates the order of the base text being commented on. Changes: - Parse base_text_order as fallback when order is not available - Look up book order by Hebrew title in addition to English title This fixes the issue where most commentary books had orderIndex=999. Closes kdroidFilter/Zayit#263
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sefaria's
table_of_contents.jsondoesn't provide anorderfield for commentary books. Instead, it providesbase_text_orderwhich indicates the order of the base text being commented on.Changes
base_text_orderas fallback whenorderis not availableBefore
Most commentary books had
orderIndex=999(default value).After
Commentary books will have proper ordering based on the order of their base text.
Closes kdroidFilter/Zayit#263