fix: Add watchOS to AVAssetDownloadTask availability check#344
Merged
fix: Add watchOS to AVAssetDownloadTask availability check#344
Conversation
AVAssetDownloadTask is not available on watchOS either, not just tvOS. Updated conditional compilation to exclude both tvOS and watchOS.
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix build failures on tvOS and watchOS platforms caused by
AVAssetDownloadTaskunavailability.Problem
The recent upstream commit (6dff47c) added a check to filter out
AVAssetDownloadTaskto prevent crashes duringswizzling. However,
AVAssetDownloadTaskis only available on iOS and macOS, causing compilation errors on tvOS andwatchOS:
❌ 'AVAssetDownloadTask' is unavailable in tvOS
❌ 'AVAssetDownloadTask' is unavailable in watchOS
Solution
Added platform-specific conditional compilation to exclude the
AVAssetDownloadTaskcheck on tvOS and watchOS: