Allow users in later time zones to get the NYT puzzle earlier.#88
Open
jonzolla wants to merge 1 commit intokebernet:masterfrom
Open
Allow users in later time zones to get the NYT puzzle earlier.#88jonzolla wants to merge 1 commit intokebernet:masterfrom
jonzolla wants to merge 1 commit intokebernet:masterfrom
Conversation
jonzolla
force-pushed
the
nyt_time
branch
4 times, most recently
from
978e424 to
b518890
Compare
jonzolla
force-pushed
the
nyt_time
branch
2 times, most recently
from
24443dd to
b518890
Compare
The puzzle is published by 12AM in America/New_York, so adjust goodThrough() for NYTDownloader to indicate the puzzle is available earlier than 12AM in the local time zone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The puzzle is published by 12AM in America/New_York, so adjust
goodThrough() for NYTDownloader to indicate the puzzle is available
earlier than 12AM in the local time zone.
Mostly addresses #20, although I think NYT puzzles may be available
even before midnight Eastern time.