Skip to content

chore(deps): bump vite to 8, vitest to 4, plugin-react to 5 (frontend)#341

Merged
padak merged 1 commit into
mainfrom
chore/bump-frontend-vite8-vitest4
May 25, 2026
Merged

chore(deps): bump vite to 8, vitest to 4, plugin-react to 5 (frontend)#341
padak merged 1 commit into
mainfrom
chore/bump-frontend-vite8-vitest4

Conversation

@padak
Copy link
Copy Markdown
Member

@padak padak commented May 25, 2026

What

Consolidated frontend dependency bump that supersedes Dependabot PRs #337 and #338.

Package From To
vite 5.4.x 8.0.14
vitest 2.x 4.1.7
@vitejs/plugin-react 4.3.x 5.2.0

Why

Both #337 and #338 bumped vite to 8 and vitest to 4 but left
@vitejs/plugin-react@^4.3.1, whose peer range tops out at vite 7
(^4 || ^5 || ^6 || ^7). That produced an npm ci ERESOLVE in the
Windows wheel-build job, which silently degraded to a UI-less wheel and
failed the "Assert the SPA is bundled" check (issue #320 Bug 1 guard).

@vitejs/plugin-react@5.2.0 is the first release whose peer range includes
vite 8 (^4 || ^5 || ^6 || ^7 || ^8) without pulling in the
@rolldown/plugin-babel / babel-plugin-react-compiler peers that
plugin-react 6 introduces — the minimal consistent upgrade.

Verification (local, against a live project)

  • npm ci resolves clean (no ERESOLVE)
  • npm run build (tsc -b && vite build) produces dist/
  • uv build bundles _ui_dist/index.html into the wheel — check_wheel_ui.py --expect-ui passes
  • kbagent serve --ui serves the SPA + assets + API; SPA renders in-browser with no console errors
  • live read-only CLI commands (project status, storage buckets) succeed

Note

The frontend has no *.test.*/*.spec.* files, so npm run test (vitest run)
exits 1 with "No test files found" — this is pre-existing (vitest 2 behaved
identically) and not run by any CI job; the wheel-build job only runs
npm ci + npm run build.

Closes #337
Closes #338


Open in Devin Review

Dependabot PRs #337 and #338 bumped vite 5->8 and vitest 2->4 but left
@vitejs/plugin-react at ^4.3.1, whose peer range tops out at vite 7. That
caused an npm ci ERESOLVE in the Windows wheel-build job, which silently
degraded to a UI-less wheel and failed the 'Assert the SPA is bundled'
check (issue #320 Bug 1 guard).

Bump @vitejs/plugin-react to ^5.2.0, the first release whose peer range
includes vite 8 (^4 || ^5 || ^6 || ^7 || ^8) without pulling in the
rolldown/babel peers that plugin-react 6 introduces. This is the minimal
consistent upgrade.

Verified locally: npm ci resolves clean, npm run build (tsc + vite 8)
produces dist/, uv build bundles _ui_dist/index.html into the wheel
(check_wheel_ui --expect-ui passes), and kbagent serve --ui renders the
SPA with no console errors against a live project.

Supersedes #337 and #338.
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 1 additional finding in Devin Review.

Open in Devin Review

Comment thread web/frontend/package.json
Comment on lines +32 to +33
"vite": "^8.0.14",
"vitest": "^4.1.7"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Major version jumps skip intermediate majors

The PR jumps vite from 5 to 8 (skipping 6 and 7) and vitest from 2 to 4 (skipping 3). While the lock file resolves cleanly and peer dependencies are satisfied, each skipped major version may have introduced breaking changes to plugin APIs, config options, or build behavior. The current vite.config.ts is minimal (just defineConfig with react() plugin, proxy, and build.target), so the risk is low — but Vite 8 notably switches the internal bundler from Rollup to Rolldown, which could surface subtle differences in build output or plugin compatibility for more complex setups. Worth a quick smoke test of npm run build and npm run dev to confirm the frontend still builds and serves correctly.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@padak padak merged commit 7c6658d into main May 25, 2026
3 checks passed
@padak padak deleted the chore/bump-frontend-vite8-vitest4 branch May 25, 2026 12:43
@padak padak mentioned this pull request May 25, 2026
padak added a commit that referenced this pull request May 25, 2026
Patch release: #336 (surface data-app logs in skill/expert) + #341 (frontend vite8/vitest4/plugin-react5 tooling fix). No CLI runtime change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant