docs(adr): add ADR 0002 — sec-09 config privilege separation#344
Merged
Conversation
Convert the free-form docs/issue-271-sec-09-config-privilege-separation.md into a formal ADR (0002) matching the docs/adr/ template (Status / Date / Context / Decision / Consequences). Decision: the permissions guard is guard rails (protects against an agent mistake), not a sandbox; a real hard lockout is an OS-level privilege- separation deployment pattern, with the robust enforcement landing in a future kbagent 'locked mode' rather than a defeatable bash allowlist. Do not build a stronger in-process isatty-style guard. Also fixes the stale padak/keboola_agent_cli issue URL to keboola/cli after the repo move.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+91
to
+94
| ### What ships now (the sec-09 decision on #271) | ||
|
|
||
| - Rewrite the misleading docstring at `permissions.py:34`. | ||
| - Ship this ADR as the authoritative "Hardened multi-user setup" reference. |
There was a problem hiding this comment.
🚩 ADR claims docstring rewrite 'ships now' but PR does not include it
The ADR's "What ships now" section (line 93) states: "Rewrite the misleading docstring at permissions.py:34." However, this PR only adds the ADR itself — the docstring at commands/permissions.py:34 still reads "This prevents AI agents from programmatically bypassing permission policies." which is exactly the claim the ADR identifies as misleading. The docstring change may be planned for a companion PR, but as written the ADR's "ships now" claim is not fulfilled by this PR alone.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Converts the free-form
docs/issue-271-sec-09-config-privilege-separation.mdinto a formal ADR —docs/adr/0002-sec-09-config-privilege-separation.md— matching the existingdocs/adr/0001template (Status / Date / Context / Decision / Consequences).Decision recorded
permissionsconfirmation guard is guard rails (protects against an agent mistake), not a sandbox. In single-user mode the agent and the policy file share one uid, so no in-process guard is enforceable.config.json, sudo-brokered wrapper, scrubbed env, pinned config), never an in-process feature.KBAGENT_NO_ADMIN+KBAGENT_LOCKED_CONFIG_DIR) in tested Python, not a defeatable bash allowlist.isatty-style guard — wrong layer.Status: Accepted (the sec-09 decision on #271).
Notes
padak/keboola_agent_cliissue URL →keboola/cliafter the repo move.Refs #271 (finding sec-09).