docs: AJDA-2839 add BigQuery section to Storage Access docs#986
Open
sykora-ji wants to merge 3 commits into
Open
docs: AJDA-2839 add BigQuery section to Storage Access docs#986sykora-ji wants to merge 3 commits into
sykora-ji wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
keboola-pr-reviewer-bot
left a comment
keboola-pr-reviewer-bot
left a comment
There was a problem hiding this comment.
Verdict: needs_human (risk 2/5) · profile docs
The PR introduces substantive product-behaviour claims about BigQuery that require human confirmation per policy Section 2.
Concerns:
src/content/docs/data-apps/storage-access/index.md: New BigQuery identifier-quoting and dataset-mangling rules are unverified product-behaviour claims.src/content/docs/data-apps/storage-access/index.md: Systematic 'Data App' → 'App' rename not in canonical-term table; needs docs-team confirmation.
Suggested reviewers: @keboola/docs
A two-part `dataset.table` reference works whether quoted per segment
(`` `dataset`.`table` ``) or as a single pair (`` `dataset.table` ``) —
per-segment quoting is not required. The real failure is adding a third
leading segment (the Keboola stage `in`/`out`, or splitting the dotted
bucket ID), which BigQuery resolves as a GCP project ("The project <stage>
has not enabled BigQuery").
Verified live against a real BigQuery project (in_c_shared_bucket.cashier-data):
`ds`.`tbl` and `ds.tbl` both succeed; `out`.`ds`.`tbl` and `out.ds.tbl` fail.
Rewrites the rule, examples, comparison table, and Limitations note; renames
the subsection heading (no internal links referenced the old anchor).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
link to issue
Description
Adds a "Working with the BigQuery Backend" section to the Storage Access (Direct Storage Access) docs page (
src/content/docs/data-apps/storage-access/index.md), which previously documented only the Snowflake backend.Changes:
:::notestating Storage Access works on both Snowflake and BigQuery, with a link to the new section.`dataset`.`table`), with theproject … has not enabled BigQueryfailure mode for the whole-FQN form, plus a Snowflake-vs-BigQuery comparison table..and-are replaced with_(e.g.out.c-Test-Data---Customers-Products-Orders→out_c_Test_Data___Customers_Products_Orders); only the dataset name is mangled, the table name keeps its original form.INFORMATION_SCHEMA.SCHEMATAmentioned as a runtime-discovery fallback.Docs-only change. Verified with a clean production build (
astro build, 254 pages) and the link/anchor audit; all internal anchors resolve.Release Notes
src/content/docs/. No effect on single-tenant setups. Not behind a feature flag.maintriggers the GitHub Actions build +aws s3 syncto help.keboola.com.