Skip to content

Make php-component 7.3 ready #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 29, 2018
Merged

Make php-component 7.3 ready #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c8130c
Run travis on 7.3
tomasfejfar Dec 25, 2018
d95f86e
Local docker from latest PHP 7
tomasfejfar Dec 25, 2018
94cd4d1
Update CS
tomasfejfar Dec 25, 2018
dfb25b3
Fix notice from phpunit
tomasfejfar Dec 25, 2018
c71bd2a
Update config to fixed version, along with other symfony components
tomasfejfar Dec 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ sudo: false
language: php

php:
- 7.1
- 7.3
- 7.2
- 7.1
- nightly

env:
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM php:7.1-cli
FROM php:7-cli

ENV COMPOSER_ALLOW_SUPERUSER 1

Expand Down
10 changes: 5 additions & 5 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,18 @@
"php": "^7.1",
"ext-json": "*",
"monolog/monolog": "^1.23",
"symfony/config": "^4.0",
"symfony/filesystem": "^4.0",
"symfony/finder": "^4.0",
"symfony/serializer": "^4.0"
"symfony/config": "^4.2",
"symfony/filesystem": "^4.2",
"symfony/finder": "^4.2",
"symfony/serializer": "^4.2"
},
"require-dev": {
"devedge/sami-github": "^1.0",
"jakub-onderka/php-parallel-lint": "^1.0",
"keboola/php-temp": "^1.0",
"phpstan/phpstan-shim": "^0.9.1",
"phpunit/phpunit": "^7.1",
"keboola/coding-standard": "^4.0"
"keboola/coding-standard": "^7.0.2"
},
"scripts": {
"tests": "phpunit",
Expand Down
1 change: 0 additions & 1 deletion phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
convertWarningsToExceptions="true"
processIsolation="false"
stopOnFailure="false"
syntaxCheck="false"
bootstrap="tests/bootstrap.php">
<testsuite name="Tests">
<directory>tests/</directory>
Expand Down
2 changes: 1 addition & 1 deletion src/BaseComponent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public function getManifestManager(): ManifestManager
return $this->manifestManager;
}

public function getLogger() : LoggerInterface
public function getLogger(): LoggerInterface
{
return $this->logger;
}
Expand Down