Skip to content

KBC-2222 Snowflake types as constants#46

Merged
jirkasemmler merged 1 commit intomasterfrom
jirka-kbc-2222-snflk-type-has-constants
Dec 1, 2021
Merged

KBC-2222 Snowflake types as constants#46
jirkasemmler merged 1 commit intomasterfrom
jirka-kbc-2222-snflk-type-has-constants

Conversation

@jirkasemmler
Copy link
Copy Markdown
Contributor

@jirkasemmler jirkasemmler commented Nov 25, 2021

Jira: KBC-2222

Snowflake datatype class has constants to be used in other libs

@jirkasemmler jirkasemmler requested review from a team and martinjunger and removed request for a team November 25, 2021 15:52
Copy link
Copy Markdown
Contributor

@martinjunger martinjunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je to jen pripravna cast, jestli to dobre chapu? V tiketu je napsano ColumnInterface is implemented, coz bude implementovano v php-table-backend-utils...

Copy link
Copy Markdown
Contributor

@martinjunger martinjunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jirkasemmler
Copy link
Copy Markdown
Contributor Author

Je to jen pripravna cast, jestli to dobre chapu? V tiketu je napsano ColumnInterface is implemented, coz bude implementovano v php-table-backend-utils...

jojo, presne tak. Ten ColumnInterface by mel pouzit prave ty konstanty at to nehardcoduju

@jirkasemmler jirkasemmler merged commit 18533b1 into master Dec 1, 2021
@jirkasemmler jirkasemmler deleted the jirka-kbc-2222-snflk-type-has-constants branch December 1, 2021 08:08
tomasfejfar pushed a commit that referenced this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants