Merged
Conversation
new manifest support
kudj
force-pushed
the
feature-new-manifest
branch
from
ec51181 to
a4be288
Compare
SgtMarmite
reviewed
Jul 8, 2024
kudj
force-pushed
the
feature-new-manifest
branch
from
c2e1781 to
48795e9
Compare
kudj
force-pushed
the
feature-new-manifest
branch
from
0c9c953 to
448f434
Compare
SgtMarmite
reviewed
Jul 8, 2024
davidesner
requested changes
Jul 8, 2024
kudj
force-pushed
the
feature-new-manifest
branch
from
8328918 to
5d72cc7
Compare
kudj
force-pushed
the
feature-new-manifest
branch
3 times, most recently
from
fad8e9a to
23bf22e
Compare
kudj
force-pushed
the
feature-new-manifest
branch
from
e74dbcf to
d88c0f9
Compare
kudj
force-pushed
the
feature-new-manifest
branch
from
52d0686 to
d88d972
Compare
davidesner
requested changes
Jul 10, 2024
kudj
force-pushed
the
feature-new-manifest
branch
from
bfffc96 to
1e5d699
Compare
davidesner
requested changes
Jul 12, 2024
| for metadata in metadata_list: | ||
| if not metadata.get('key') and metadata.get('value'): | ||
| continue | ||
| key = metadata['key'] |
Collaborator
There was a problem hiding this comment.
@kudj tohle uz jsem rikal v predchozim commentu, ktery je ted nedohledatelny (protoze jsi delal force-push, na tohle bacha pokazdy musis udelat pull nebo radsi rebase kdyz je v destination zmena. Jinak prepises praci nekomu jinymu). Table metadata ma simplified strukturu v novym manifestu jako key:value, takze {key:x, value:x} nebude fungovat.
Contributor
Author
There was a problem hiding this comment.
Collaborator
|
Uz to vypada dobre, jen par veci:
|
davidesner
requested changes
Jul 12, 2024
| for col in val: | ||
| if col not in self.columns: | ||
| self.schema[col] = ColumnDefinition() | ||
| self.schema[col] = ColumnDefinition() |
Collaborator
There was a problem hiding this comment.
Promin ale tohle porad neni to co jsem myslel 4f3c6dd#diff-6615ea46ac4ee88c1db70b9f0623e257843f25b60b46d65de76a2c8fdbac64bcR1246 tady to potichu zarve a uzivatel si bude myslet ze se neco stalo, ale nic se nestalo. Zachoval bych tu puvodni funkcionalitu a tady prepsal cely schema a vyhodil ten check
Contributor
Author
There was a problem hiding this comment.
změněno, takže uživatel si může přepsat celé schema jen nastavením columns a jenom to vypíše warning?
Contributor
Author
|
@davidesner native_types a new_manifest nahrazeny legacy_manifestem který se nastavuje podle KBC_DATA_TYPE_SUPPORT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.