Skip to content

Refactor/new structure#59

Merged
davidesner merged 10 commits intomainfrom
refactor/new-structure
Jul 19, 2024
Merged

Refactor/new structure#59
davidesner merged 10 commits intomainfrom
refactor/new-structure

Conversation

@davidesner
Copy link
Copy Markdown
Collaborator

@davidesner davidesner commented Jul 18, 2024

  • Backward compatibility for legacy manifests on input as well as output
    • this means that it is possible to have empty columns and filled primary key, in which case the manifest will be always forced to legacy.
    • Fixed BaseType class type and added convenience methods
    • has_headers configurable from interface
    • Fixed tests, split to more so it's "unit" test
    • Remove columns as named attribute from every api, keeping it in kwargs for backward compatibility
    • Removed calls to legacy methods internally.
    • Added tests for original attribute order compatibility + replacing columns with schema, allowing for list of strings

@davidesner davidesner requested a review from kudj July 18, 2024 11:11
@davidesner davidesner force-pushed the refactor/new-structure branch from dee1bc1 to 420d7a7 Compare July 18, 2024 11:24
@davidesner davidesner force-pushed the refactor/new-structure branch 2 times, most recently from 9624696 to 588c824 Compare July 18, 2024 11:56
@davidesner davidesner force-pushed the refactor/new-structure branch 2 times, most recently from c04deb0 to 34fa206 Compare July 18, 2024 13:32
@davidesner davidesner force-pushed the refactor/new-structure branch from b894626 to a157f13 Compare July 18, 2024 13:33
@davidesner davidesner merged commit b215fc3 into main Jul 19, 2024
@davidesner davidesner deleted the refactor/new-structure branch July 19, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants