Skip to content

Fix/legacy manifest columns vs has header#74

Merged
kudj merged 5 commits intomainfrom
fix/legacy-manifest-columns-vs-has-header
Jan 17, 2025
Merged

Fix/legacy manifest columns vs has header#74
kudj merged 5 commits intomainfrom
fix/legacy-manifest-columns-vs-has-header

Conversation

@kudj
Copy link
Copy Markdown
Contributor

@kudj kudj commented Jan 14, 2025

No description provided.

}

if legacy_manifest or self.stage == 'in':
if (legacy_manifest and not self.has_header) or self.stage == 'in':
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will just quote docs here for a future reference:

Using the columns field currently means that the data file must not contain header.

https://keboola.atlassian.net/wiki/spaces/ENGG/pages/3099787265/PENDING+RFC-2023-016+Native+Data+types+Take+2#Changes-to-manifest-structure

@kudj kudj merged commit 58c75d4 into main Jan 17, 2025
@kudj kudj deleted the fix/legacy-manifest-columns-vs-has-header branch January 17, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not output columns if has_headers is explicitly set to true and component run in legacy mode.

2 participants