fix(vcr): suppress vcr/urllib3 debug logging during cassette replay#92
Merged
matyas-jirat-keboola merged 2 commits intomainfrom Mar 5, 2026
Merged
Conversation
record_debug_run() already suppresses these loggers at WARNING level, but _execute_with_vcr_replay() did not — causing ~1 DEBUG line per cassette interaction to flood stdout during local debug runs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…eplay Remove redundant local `import logging` — already imported at module top. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Applied to feature/vcr-auto-recording instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_execute_with_vcr_replay()was not suppressingvcrandurllib3loggers, causing one DEBUG line per cassette interaction to flood stdout during local debug runs (e.g. ~995 lines for a typical Facebook Pages job)record_debug_run()already suppresses these loggers at WARNING — this brings replay in line with the same behaviourTest plan
data/cassettes/requests.jsonpresent — stdout should only show component-level INFO/WARNING/ERROR, no vcrpyAppending request...lines🤖 Generated with Claude Code