Conversation
Member
odinuv
commented
May 22, 2023
odinuv
commented
- add branch_id option
- add basic calls for working with configurations
pivnicek
reviewed
May 22, 2023
Contributor
pivnicek
left a comment
pivnicek
left a comment
There was a problem hiding this comment.
Looks great, just noticed a couple of things
Comment on lines
+39
to
+43
| if not isinstance(component_id, str) or component_id == '': | ||
| raise ValueError("Invalid component_id '{}'.".format(component_id)) | ||
| if not isinstance(configuration_id, str) or configuration_id == '': | ||
| raise ValueError("Invalid component_id '{}'.".format(configuration_id)) | ||
| url = '{}/{}/configs/{}'.format(self.base_url, component_id, configuration_id) |
Contributor
There was a problem hiding this comment.
Do we want to accept empty strings? Doesn't the detail call require values?
Member
Author
There was a problem hiding this comment.
If component_id is an empty string, it raises an error, doesn't it?
Contributor
There was a problem hiding this comment.
omg, sorry, I don't know how to read a simple conditional statement 🤦
Comment on lines
+57
to
+60
| if not isinstance(component_id, str) or component_id == '': | ||
| raise ValueError("Invalid component_id '{}'.".format(component_id)) | ||
| if not isinstance(configuration_id, str) or configuration_id == '': | ||
| raise ValueError("Invalid component_id '{}'.".format(configuration_id)) |
- add basic calls for working with configurations
Co-authored-by: Marc <pivnicek@users.noreply.github.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.