Conversation
tomasfejfar
reviewed
Apr 25, 2024
Contributor
tomasfejfar
left a comment
tomasfejfar
left a comment
There was a problem hiding this comment.
IMHO this should be tested within the client itself, not "somewhere else". It needs to be executed as part of client release that any API change did not break it.
Contributor
|
(if the above is not clear) There should be a test created that uses an ENV variable that contains token to a GCP project. That env variable will be stored as secret in this repo. In the test you will use the client authorized with the token from env variable to upload and assert the file's existence. You should provide the test that looks for the ENV variable. We (or you when you're admin of this repo already) will set the ENV for the repo to some testing project token. |
tomasfejfar
approved these changes
Apr 29, 2024
Contributor
tomasfejfar
left a comment
tomasfejfar
left a comment
There was a problem hiding this comment.
Super, s testy je to 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tested here: https://connection.europe-west3.gcp.keboola.com/admin/projects/220/queue/335678