Conversation
tomasfejfar
left a comment
tomasfejfar
left a comment
There was a problem hiding this comment.
Let's see what @odinuv
kbcstorage/retry_requests.py
Outdated
| import time | ||
| import requests | ||
|
|
||
| MAX_RETRIES = 11 |
There was a problem hiding this comment.
Why 10 retries? That means 17 minutes request if the service is down completely.
There was a problem hiding this comment.
There was a problem hiding this comment.
I don't think we have 10 retries in SAPI, do we?
There was a problem hiding this comment.
There was a problem hiding this comment.
Tak jsme to rozmotali, jak to je. Zásadní totiž je, že v php clientovi je to konfigurovatelné. Tím pádem tam, kde je to nějaký worker, který běží nekonečně je použitý default nebo i víc. A pak když je to používané někde v rámci requestu, tak je to zkrácené třeba na 3 pokusy. Tak prosím tady stejně. Tj. konfigurovatelné parametrem konstruktoru jako v té PHP verzi.
|
Also, while you're at it, please replace |
tomasfejfar
left a comment
tomasfejfar
left a comment
There was a problem hiding this comment.
LGTM now, it will be battle tested when you use it :)
3 participants
No description provided.