Skip to content

Synapse table create + drop#397

Merged
ErikZigo merged 6 commits intomasterfrom
erik-table-create-KBC-202
Apr 7, 2020
Merged

Synapse table create + drop#397
ErikZigo merged 6 commits intomasterfrom
erik-table-create-KBC-202

Conversation

@ErikZigo
Copy link
Copy Markdown
Contributor

@ErikZigo ErikZigo commented Apr 6, 2020

No description provided.

@ErikZigo ErikZigo changed the title wip: Synapse table create + drop Synapse table create + drop Apr 7, 2020
ErikZigo
ErikZigo commented Apr 7, 2020
View reviewed changes
Comment thread src/Keboola/StorageApi/Client.php
ErikZigo
ErikZigo commented Apr 7, 2020
View reviewed changes
Comment thread tests/Backend/CommonPart1/CreateTableTest.php
ErikZigo
ErikZigo commented Apr 7, 2020
View reviewed changes
Comment thread phpunit.xml.dist
Comment on lines +88 to +92
<testsuite name="backend-synapse-part-1">
<file>tests/Backend/CommonPart1/BucketsTest.php</file>
<file>tests/Backend/Synapse/CreateTableTest.php</file>
<file>tests/Backend/Synapse/ImportExportCommonTest.php</file>
</testsuite>
Copy link
Copy Markdown
Contributor Author

@ErikZigo ErikZigo Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synapse má vlastní suite. Postupně tam budou přibývat testy.

ErikZigo
ErikZigo commented Apr 7, 2020
View reviewed changes
Comment thread tests/Backend/Synapse/CreateTableTest.php
@ErikZigo ErikZigo requested a review from zajca April 7, 2020 07:24
zajca
zajca approved these changes Apr 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@zajca zajca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Podle mě cajk, je tam víc testů co by šli pustit pro import/export, ale to asi pořeším spíš já, protože sem to dělal.
Zajímavé, že sem nedošel, na ty abs testy, budu tam muset přidat víc common testů, udělám na to story.

@ErikZigo
Copy link
Copy Markdown
Contributor Author

ErikZigo commented Apr 7, 2020

No šlo by tam asi už přidat i něco z SlicedImportsTest. Ale to je na refactoring toho testu, protože to počítá jen s S3 filestorage a není tam test pro azure. To bude chtít asi péči zvlášť.

@zajca
Copy link
Copy Markdown
Member

zajca commented Apr 7, 2020

No šlo by tam asi už přidat i něco z SlicedImportsTest. Ale to je na refactoring toho testu, protože to počítá jen s S3 filestorage a není tam test pro azure. To bude chtít asi péči zvlášť.

Udělal sem na to vlastní story.

@ErikZigo ErikZigo force-pushed the erik-table-create-KBC-202 branch from 572566a to c03f489 Compare April 7, 2020 10:12
@ErikZigo
Copy link
Copy Markdown
Contributor Author

ErikZigo commented Apr 7, 2020

rebase

@ErikZigo ErikZigo merged commit 2dda027 into master Apr 7, 2020
@ErikZigo ErikZigo deleted the erik-table-create-KBC-202 branch April 7, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zajca zajca zajca approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ErikZigo @zajca