The example was noop (30megs -> 30 megs)#117
Open
jkremser wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the example PodResourceProfile test data so the deployment starts with a higher memory request and then reduces it after a short delay, matching the PR description (50M initially, 30M after 30s).
Changes:
- Increase the Deployment container memory request from
30Mto50M. - Keep the PodResourceProfile’s
newResources.requests.memoryat30M(applied afterdelay: 30s).
Comments suppressed due to low confidence (1)
test-data/resources/prp.yaml:43
- The file now ends with an extra blank line (and trailing whitespace) after
newResources.requests.memory. This adds noise to diffs and can trip whitespace/lint checks; please remove the trailing empty/whitespace-only lines.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
w/ this it's 50 megs by default and after 30 seconds the requests for memory are lowered to 30 megs