-
Notifications
You must be signed in to change notification settings - Fork 43
Description
Hi, I'd like to have direct access to configuring proxy servers for the client to call through without environmental variables.
I'm willing to issue a pull request . I'd like to just run over the design I'm thinking of. Please point me in a different direction if you would like something else.
I was going to add a method: KeenConfig.setProxy(url). Internally this would create a java.net.Proxy instance for use with the HttpURLConnection in KeenHttpRequestRunnable.
I am more reluctant about the username and password. The only way I know of to set the authentication with HttpURLConnection is to set the default authenticator. This is a global variable. So I would rather not do that from code unless you moved to a library that supported it like (I think) Apache HttpClient. I personally don't need the authentication end, but I wanted to include it here for your thoughts.