Conversation
This change adds a signer bonds escrow strategy which holds the bonds withdrawn by the risk manager and allows the governance to transfer them to an arbitrary account.
Added tests which check whether the risk manager processes the signer bonds in a correct way and triggers a processing strategy.
# Conflicts: # contracts/RiskManagerV1.sol
Member
Author
|
Ready for review. Will undraft once #26 lands on |
# Conflicts: # contracts/RiskManagerV1.sol # contracts/test/DepositStub.sol # test/RiskManagerV1.test.js
pdyraga
reviewed
May 18, 2021
# Conflicts: # contracts/RiskManagerV1.sol # test/RiskManagerV1.test.js # test/liquidation/liquidation.test.js
pdyraga
reviewed
May 19, 2021
pdyraga
reviewed
May 19, 2021
pdyraga
approved these changes
May 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: #26
ETH purchased by the risk manager from tBTC signer bonds needs to be swapped and deposited back to the coverage pool as collateral. In the case it can not be done automatically, the governance has the power to ask the risk manager to deposit ETH from purchased signer bonds into an escrow the governance can later withdraw from and do the swap manually.
SignerBondsEscrowis a simple escrow implementation allowing the risk manager to store purchased ETH signer bonds so that governance can later swap them manually and deposit as coverage pool collateral.