Restore reward eligibility by operator address#182
Merged
Conversation
The off-chain client can monitor the reward eligibility and restore it when the time comes but it is easier for the client to use the operator address instead of the operator ID. Looking at the public API so far, the reward eligibility was getting restored using the address so it makes sense to have all other reward-eligibility-related functions use the operator address as well, for consistency.
dimpar
reviewed
Jul 13, 2022
|
|
||
| await pool.connect(owner).setRewardIneligibility([bobID], now + 100) | ||
|
|
||
| await expect(await pool.isEligibleForRewards(bob.address)).to.be.false |
Contributor
There was a problem hiding this comment.
All the await before expect can be removed.
Contributor
|
lgtm, no more comments |
dimpar
approved these changes
Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs threshold-network/keep-core#3008
The off-chain client can monitor the reward eligibility and restore it when the
time comes but it is easier for the client to use the operator address instead
of the operator ID.
Looking at the public API so far, the reward eligibility was getting restored
using the address so it makes sense to have all other reward-eligibility-related
functions use the operator address as well, for consistency.