Improve handling of remote sync saving#11873
Merged
droidmonkey merged 2 commits intodevelopfrom Mar 30, 2025
Merged
Conversation
droidmonkey
added
pr: tests
droidmonkey
force-pushed
the
fix/remote-sync-tests
branch
from
3289e15 to
8779721
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #11873 +/- ##
===========================================
- Coverage 63.93% 63.90% -0.04%
===========================================
Files 369 369
Lines 38929 38920 -9
===========================================
- Hits 24889 24868 -21
- Misses 14040 14052 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
phoerious
reviewed
Mar 11, 2025
droidmonkey
force-pushed
the
fix/remote-sync-tests
branch
6 times, most recently
from
5dafd4b to
80a14ad
Compare
phoerious
approved these changes
Mar 16, 2025
droidmonkey
force-pushed
the
fix/remote-sync-tests
branch
2 times, most recently
from
8ddd2bc to
cb35d34
Compare
* Fixes sporadic failures on gui tests on Windows * Corrects inability to write to temporary config file while running tests * Corrects errors when using MockRemoteProcess due to missing functions
droidmonkey
force-pushed
the
fix/remote-sync-tests
branch
from
cb35d34 to
3969806
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing strategy
Tested extensively on local windows box. Able to reproduce the test failure 6/10 times before change, cannot reproduce test failure at all after change. Used Process Monitor to find issues with file read/write during tests.
Type of change