Skip to content

chore: several improvements based on feedback#3576

Merged
talboren merged 11 commits intomainfrom
feat/a-few-imporvements
Feb 20, 2025
Merged

chore: several improvements based on feedback#3576
talboren merged 11 commits intomainfrom
feat/a-few-imporvements

Conversation

@talboren
Copy link
Copy Markdown
Member

@talboren talboren commented Feb 19, 2025 •
edited
Loading

close #3549
close #3548

  • Fixed incident status change to acknowledge to ack alerts too
  • Looking at some alert will show an icon that this alert was viewed before and highlight the last alert that was looked at
    CleanShot 2025-02-19 at 16 30 50
  • Alert self-assign changes the alert status to acknowledged
  • Incident status change audit message
  • Incident status change assignes changing user
  • Removed fingerprint from AlertEventInfo
  • Workflow execution doesn't take you to the execution but proposes in Toast
    CleanShot 2025-02-19 at 16 36 32
  • Filter resolved and deleted incidents with alert association modal

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 7:07pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Feedback Based on customer feedback UI User interface related issues labels Feb 19, 2025
@shahargl
Copy link
Copy Markdown
Member

shahargl commented Feb 19, 2025

/linkedin post

@talboren talboren force-pushed the feat/a-few-imporvements branch from 23dc3c0 to 6806470 Compare February 19, 2025 14:57
Matvey-Kuk
Matvey-Kuk previously approved these changes Feb 19, 2025
View reviewed changes
@talboren talboren changed the title chore: several improvements based on feedback [WIP] chore: several improvements based on feedback Feb 19, 2025
@talboren talboren force-pushed the feat/a-few-imporvements branch from eb42833 to b5bb5fb Compare February 19, 2025 18:18
@talboren talboren changed the title [WIP] chore: several improvements based on feedback chore: several improvements based on feedback Feb 19, 2025
shahargl
shahargl approved these changes Feb 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 19, 2025
@talboren talboren merged commit 667cc7c into main Feb 20, 2025
16 of 17 checks passed
@talboren talboren deleted the feat/a-few-imporvements branch February 20, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahargl shahargl shahargl approved these changes

+1 more reviewer

@Matvey-Kuk Matvey-Kuk Matvey-Kuk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feedback Based on customer feedback lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. UI User interface related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Self assign should acknowledge the alert, changing status should self-assign [➕ Feature]: Viewed alert should stay focused

3 participants

@talboren @shahargl @Matvey-Kuk