-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: allow using latest providerId and alter UI display #4272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@tuantran0910 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
|
@tuantran0910 thank you for the contribution. I have to admit that I'm missing the before/after difference. Can you point me to where can I see the changes? It seems like both are still displaying the id of the provider. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @talboren, here is the difference, just rename
Actually, these are the names of the providers and their IDs are UUID-like string like this :D
|
talboren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks @talboren for the approval :D Can you help me to see what happened with the E2E tests. It seems that I don't have permission for those tests right ? |
I think it has something to do with a change in the e2e workflow we did, which caches and pulls images, and requires some other permissions now. I've re-run it and if it fails again, will fix and merge on Sunday. |


Closes #4271
📑 Description
When provisioning a provider and sending an alert with an incorrect providerId (one that does not belong to the provisioned provider), the alert gets permanently associated with the wrong provider.
If the same alert is sent again (with partial deduplication) using the correct providerId, it still retains the previously assigned incorrect
providerId. We should allow the providerId to be updated to the latest value.✅ Checks
ℹ Additional Information
Here’s a clearer and more polished version of your text:
I have configured alerts to be sent to Keep via a generic webhook endpoint. For the provisioned provider A with ID
123, I decided to add the query parameter?provider_id=123.On the Provider page, each provider card was incorrectly displaying the
idfield instead of thenamefield. I have updated it to display thenamefield correctly.Before
After
Additionally, the spacing between the icon and the provider name was too tight, affecting readability. I have added some spacing for better clarity.
Before
After