Merged
Conversation
|
@piekarski-mateusz is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Target branch is not in the allowed branches list. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5522 +/- ##
===========================================
- Coverage 46.39% 30.54% -15.86%
===========================================
Files 176 101 -75
Lines 18412 11669 -6743
===========================================
- Hits 8543 3564 -4979
+ Misses 9869 8105 -1764 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5524
📑 Description
When using
OAUTH2PROXYauthentication (oauth2-proxy + FusionAuth), clicking "Sign Out" in the UI would immediately log the user back in. This happened because:signOut()only clears the local session cookieSince oauth2-proxy still has a valid session, it automatically re-authenticates the user on the next request.
shared/lib/hooks/useSignOut.ts- Check forOAUTH2PROXYauth type and redirect to/oauth2/sign_outshared/api/ApiClient.ts- Same handling for automatic sign-out on 401 responsesuseSignOuthook (8 tests)ApiClient(6 tests)✅ Checks
ℹ Additional Information