Skip to content

feat: add title support and summary cleanup to pushover provider#5710

Merged
shahargl merged 6 commits intokeephq:mainfrom
Skrotdev:pushover-title
Apr 14, 2026
Merged

feat: add title support and summary cleanup to pushover provider#5710
shahargl merged 6 commits intokeephq:mainfrom
Skrotdev:pushover-title

Conversation

@Skrotdev
Copy link
Copy Markdown
Contributor

@Skrotdev Skrotdev commented Mar 3, 2026

📑 Description

This PR improves Pushover notifications for incident workflows.
It adds support for sending an incident title and improves message formatting so notifications are cleaner and easier to read.

  • Added optional title support for Pushover notifications.
  • Cleaned message text by removing paragraph HTML tags (<p> and </p>).
  • Kept existing runtime options (sound, priority, retry, expire) working as before.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Fixes #6105

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 3, 2026

Target branch is not in the allowed branches list.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 3, 2026

@Skrotdev is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Feature A new feature Provider Providers related issues labels Mar 3, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.49%. Comparing base (5fc042d) to head (eab713d).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5710       +/-   ##
===========================================
- Coverage   46.41%   30.49%   -15.92%     
===========================================
  Files         176      101       -75     
  Lines       18443    11689     -6754     
===========================================
- Hits         8561     3565     -4996     
+ Misses       9882     8124     -1758     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 14, 2026
@shahargl shahargl enabled auto-merge (squash) April 14, 2026 00:03
@shahargl shahargl disabled auto-merge April 14, 2026 00:03
@shahargl shahargl merged commit 339151c into keephq:main Apr 14, 2026
15 of 18 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🌟 Well done @Skrotdev! Two PRs merged already! 🎉🥳

With your second PR, you're on a roll, and your contributions are already making a difference. 🌟
Looking forward to seeing even more contributions from you. See you in Slack https://slack.keephq.dev 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature A new feature lgtm This PR has been approved by a maintainer Provider Providers related issues size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ ➕ Feature]: Add title support and summary cleanup to Pushover provider

2 participants