fix: expose is_visible in IncidentDto for workflow conditions#6282
Merged
Conversation
The is_visible field exists on the database Incident model but was
missing from IncidentDto, causing {{ incident.is_visible }} to resolve
to an empty string in workflow if-conditions.
Add is_visible to IncidentDto, from_db_incident(), and to_db_incident()
for round-trip consistency, matching the existing pattern used by
is_predicted and is_candidate.
Closes keephq#6279
dosubot
Bot
added
size:XS
Contributor
Author
|
Hi @shahargl, CI green — ready for review when you get a chance. Thanks! |
Contributor
|
🎊 Well done @alpar! Two PRs merged already! 🎉🥳 With your second PR, you're on a roll, and your contributions are already making a difference. 🌟 |
wsimon1982
pushed a commit
to wsimon1982/keep
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
{{ incident.is_visible }}resolves to an empty string in workflow if-conditions, even though the database hasis_visible = t. This causes actions to be incorrectly skipped.Reported in #6279.
Root Cause
The
is_visiblefield exists on the databaseIncidentmodel but was not included inIncidentDto. Thefrom_db_incident()method maps many fields but skippedis_visible, so when the workflow engine renders{{ incident.is_visible }}, Mustache finds an empty value.Notably, the similar boolean flags
is_candidateandis_predictedare already exposed in the DTO —is_visiblewas just missed when it was introduced.Fix
Add
is_visibletoIncidentDtoand its serialization methods, following the exact same pattern asis_predictedandis_candidate:is_visible: bool = Truefield toIncidentDtois_visible=db_incident.is_visibleinfrom_db_incident()is_visible=self.is_visibleinto_db_incident()for round-trip consistencyTesting
Added two unit tests:
test_incident_dto_is_visible_from_db: verifiesfrom_db_incident()correctly mapsis_visiblefor both True and False valuestest_incident_dto_is_visible_to_db: verifiesto_db_incident()preservesis_visibleCloses #6279