fix: Prefix "Possible" in Incident Title Based on is_candidate Value#6517
Merged
Conversation
dosubot
Bot
added
size:XS
Contributor
|
🎊 Well done @PrometheRus! Two PRs merged already! 🎉🥳 With your second PR, you're on a roll, and your contributions are already making a difference. 🌟 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6516
📑 Description
This PR fixes a logical error in the Incident Header UI regarding the "Possible" prefix.
Currently, the logic is inverted:
is_candidate = false(not requiring validation) are incorrectly prefixed with "Possible ".is_candidate = true(requiring manual approval/AI-suggested) do not have the prefixThe Fix:
Updated
keep-ui/app/(keep)/incidents/[id]/incident-header.tsxto correctly apply the prefix based on theis_candidateflag:is_candidateistrue→ Show "Possible " (indicates validation needed).is_candidateisfalse→ Show no prefix (indicates confirmed incident).✅ Checks
Additional Information
The term "Possible" implies uncertainty. In the current implementation, confirmed incidents were labeled as "Possible," while unverified (candidate) incidents lacked this warning. This caused confusion for operators managing incidents.