feat(bip85): update proto contract — display-only response#94
Closed
BitHighlander wants to merge 1 commit intomasterfrom
Closed
feat(bip85): update proto contract — display-only response#94BitHighlander wants to merge 1 commit intomasterfrom
BitHighlander wants to merge 1 commit intomasterfrom
Conversation
- GetBip85Mnemonic now returns Success (mnemonic shown on device only) - Bip85Mnemonic message retained for wire compatibility with older firmware - Mnemonic never leaves device over USB Security improvement: prevents host-side mnemonic exposure.
Merged
5 tasks
Collaborator
Author
|
Superseded by combined PR #100 for simpler review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetBip85Mnemonicnow returnsSuccess— mnemonic shown on device screen only, never sent over USBBip85Mnemonicmessage retained for wire compatibility with older firmwareFiles
messages.proto— doc/comment updates only, no wire ID changesFirmware dependency
Unblocks keepkey/keepkey-firmware BIP-85 display-only feature (7.14.0)
Test plan
protoccompiles cleanlyBip85Mnemonic