feat(evm): EthereumTxMetadata for clear-signing#95
Closed
BitHighlander wants to merge 1 commit intomasterfrom
Closed
feat(evm): EthereumTxMetadata for clear-signing#95BitHighlander wants to merge 1 commit intomasterfrom
BitHighlander wants to merge 1 commit intomasterfrom
Conversation
- EthereumTxMetadata message (signed_payload, metadata_version, key_id) - EthereumMetadataAck response (classification, display_summary) - Wire IDs 115-116 - nanopb options for payload size limits Enables firmware to verify signed transaction metadata from external insight service before confirming EVM transactions.
Merged
5 tasks
Collaborator
Author
|
Superseded by combined PR #100 for simpler review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EthereumTxMetadatamessage (signed_payload, metadata_version, key_id)EthereumMetadataAckresponse (classification, display_summary)Enables firmware to verify signed transaction metadata from an external
insight service before confirming EVM transactions.
Files
messages-ethereum.proto— two new messagesmessages-ethereum.options— nanopb size limitsmessages.proto— wire ID registration (115-116)Firmware dependency
Unblocks keepkey/keepkey-firmware EVM clear-signing feature (7.14.0)
Test plan
protoccompiles cleanly