feat(ton): clear-signing fields and memo support#98
Closed
BitHighlander wants to merge 2 commits intomasterfrom
Closed
feat(ton): clear-signing fields and memo support#98BitHighlander wants to merge 2 commits intomasterfrom
BitHighlander wants to merge 2 commits intomasterfrom
Conversation
- to_address, amount, memo fields on TonSignTx - Enables firmware v4r2 body cell hash verification - memo max_size nanopb option
Merged
5 tasks
Collaborator
Author
|
Superseded by combined PR #100 for simpler review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
to_address,amount,seqno,expire_at,memofields onTonSignTxmemonanopb max_size:121messages-ton.prototo package build scriptsEnables firmware v4r2 body cell hash verification for clear-sign UX.
Device reconstructs unsigned body cell, verifies hash matches raw_tx.
Files
messages-ton.proto— new optional fields + mode documentationmessages-ton.options— memo size limitpackage.json— build script updatedFirmware dependency
Unblocks keepkey/keepkey-firmware TON support (7.14.0)
Test plan
protoccompiles cleanlynpm run buildsucceeds and emits TON types