feat(zcash): Orchard shielded transaction protocol#99
Closed
BitHighlander wants to merge 2 commits intomasterfrom
Closed
feat(zcash): Orchard shielded transaction protocol#99BitHighlander wants to merge 2 commits intomasterfrom
BitHighlander wants to merge 2 commits intomasterfrom
Conversation
- PCZT streaming protocol: ZcashSignPCZT, ZcashPCZTAction, ZcashPCZTActionAck - Orchard FVK: ZcashGetOrchardFVK, ZcashOrchardFVK - Transparent shielding: ZcashTransparentInput, ZcashTransparentSig - Wire IDs 1300-1307 - nanopb options for all fields Multi-phase protocol: session init → action streaming → transparent signing. Supports on-device Orchard digest verification via sub-digest fields.
Merged
5 tasks
Collaborator
Author
|
Superseded by combined PR #100 for simpler review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ZcashSignPCZT→ZcashPCZTAction→ZcashSignedPCZTZcashGetOrchardFVK→ZcashOrchardFVKZcashTransparentInput→ZcashTransparentSigmessages-zcash.prototo package build scriptsMulti-phase protocol for Zcash Orchard shielded transactions:
Files
messages-zcash.proto— new file (150 lines, full protocol)messages-zcash.options— nanopb limits (new file)messages.proto— wire ID registration (1300-1307)package.json— build script updatedFirmware dependency
Unblocks keepkey/keepkey-firmware Zcash Orchard support (7.14.0)
Test plan
protoccompiles cleanlynpm run buildsucceeds and emits Zcash types