fix(masking): default MetaMask masking ON; readable contrast on Settings text#63
Merged
BitHighlander merged 1 commit intodevelopfrom May 1, 2026
Merged
Conversation
…ngs text Two pain points reported on the side-panel Settings screen. 1) MetaMask masking now defaults to ON. CowSwap and several aggregators expect a window.ethereum with isMetaMask:true and bail out of their connect flow without it. Modern dApps that discover wallets via EIP-6963 still see KeepKey as itself, so this is purely additive coverage. Existing installs keep whatever they previously set; only fresh installs (or storage resets) pick up the new default. 2) The two body-text labels under "Enable Masking" used color="gray.500" which is unreadable on the side panel's dark background — black-on-black for the part the user most needs to see (the conflict warning). Switched to whiteAlpha.700, the codebase convention for secondary copy on dark surfaces (Connect.tsx, Balances.tsx, Tokens.tsx, CustomTokenDialog.tsx all use it). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
BitHighlander
added a commit
that referenced
this pull request
May 1, 2026
Cumulative since 0.0.28: #57 feat: Pioneer-sourced EVM chain registry + Solana sign-message UX #58 feat(ux): risk-tiered approval colors, hex dump + copy, deep-link Chainlist, typed timeouts #59 fix(eth): RPC failover on broadcast + pin networks on JsonRpcProvider #60 fix(audit): UTXO build race + cross-chain broadcast resilience + read failover #61 fix: drop orphaned approval events on service-worker startup #62 fix(eth): read handlers participate in failover; method-rejection counted as transient #63 fix(masking): default MetaMask masking ON; readable contrast on Settings text Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues on the Side Panel → Settings → "Enable Masking" surface
1. MetaMask masking now defaults to ON
CowSwap and several swap aggregators bail out of their connect flow without a
window.ethereumcarryingisMetaMask: true. Modern dApps that discover wallets via EIP-6963 still see KeepKey as itself, so flipping the default is purely additive — sites that work with the masking off still work, and sites that need it stop being broken on first install.Existing installs keep whatever they previously set (chrome.storage persists the boolean once it's been read). Only fresh installs / cleared storage pick up the new default. If we want to forcibly upgrade existing users (e.g. one-time migration that flips false→true once), that's a separate change — call it out and I'll add it.
2. The body-text labels were unreadable
color="gray.500"is fine on a light background but the side panel's dark theme makes it ~black-on-black. The two affected lines are the MetaMask description and the conflict-warning under the Coming Soon rows — the latter being exactly the part the user most needs to see.Switched both to
color="whiteAlpha.700", the codebase convention for secondary copy on dark surfaces (used inConnect.tsx,Balances.tsx,Tokens.tsx,CustomTokenDialog.tsx).Files
packages/storage/lib/customStorage.ts—enableMetaMaskMasking: false→truein the masking-settings storage default.pages/side-panel/src/components/Settings.tsx— twogray.500→whiteAlpha.700color swaps.Test plan
🤖 Generated with Claude Code