Serde Deserialize+Serialize implementation#440
Conversation
|
CI jobs are currently failing since clippy isn't being run with features enabled. Line 1286 in |
keepsimple1
left a comment
There was a problem hiding this comment.
Looks good! One inline comment related to the CI error. And optional, if you have bandwidth, you can also add a new step in CI to run cargo clippy --tests --all-features -- -D warnings to cover the features (I think).
|
Also, one small thing to note. Currently, when there is no @keepsimple1 My question to you is, should this be considered intended behavior as it reflects the internal representation with how the struct is implemented in Rust (uses default empty values as opposed to
|
I think we should keep it as is because Btw, now |
To my knowledge, an IPv6 address is not always accompanied by a scope ID. I may be wrong. I will work on finalizing this PR today. |
|
Alright everything should be ready to go! If you'd like, take one last look over everything. I moved the serde test into its own submodule so clippy would stop complaining about unused imports. |

This PR introduces a new feature flag:
serdeI've implemented the
SerializeandDeserializetraits usingderiveforResolvedServiceand for all the local types which it contains.Additionally, I've also written a basic test to accompany the changes and added
serde_jsonas a development dependency.If there is a benefit to providing
serdesupport for types other thanResolvedService, please comment that.Closes: #438