Fix ScopedIp serialization with MessagePack#472
Merged
Conversation
keepsimple1
reviewed
May 22, 2026
Owner
keepsimple1
left a comment
keepsimple1
left a comment
There was a problem hiding this comment.
I'm OK with the change. The only thing is that this is a breaking change.
Let's think a bit more for a day. (My current thought is that this change is good for long term)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
serde(untagged)attribute on Enums breaks serialization with binary formats like MessagePack.I originally added that tag to optimize the redundant structures when serializing, but this can also be achieved when using
serde(flatten)on a per-implementation basis.Through my own testing using
rmp-serde, I can confirm that it works after this change. If requested, I can write an additional test to cover this case.EDIT: Actually not a problem with the format, seems like it's an issue with rmp-serde.