Skip to content

chore: configure editor, update deps, linting fix files and fix small UX/formatting#18

Merged
kegren merged 3 commits intomainfrom
chore-configure-editor-update-deps
Jan 1, 2026
Merged

chore: configure editor, update deps, linting fix files and fix small UX/formatting#18
kegren merged 3 commits intomainfrom
chore-configure-editor-update-deps

Conversation

@kegren
Copy link
Owner

@kegren kegren commented Jan 1, 2026

No description provided.

kegren added 2 commits January 1, 2026 22:31
Condense biome.jsonc extends array into a single line and comment out
the Typecheck step in the GitHub Actions CI workflow.

- Comment out the 'Typecheck' job step in .github/workflows/ci.yml so the
  CI no longer runs bun typecheck. This is done temporarily because the
  current linter (Ultracite/Biome) checks syntax but type-checking must
  be handled separately; disabling it avoids CI failures while other
  fixes or migrations are underway.
- Reformat biome.jsonc extends array onto one line for readability
  and to reduce diff noise from multi-line list formatting.
@greptile-apps
Copy link

greptile-apps bot commented Jan 1, 2026

Greptile Summary

This PR configures editor tooling, updates dependencies, and applies linting fixes across the codebase. The changes standardize code formatting using Ultracite/Biome and set up pre-commit hooks with Husky.

Major Changes:

  • Migrated from direct Biome usage to Ultracite 7.0.4 CLI wrapper
  • Added Husky for git hooks with pre-commit formatting automation
  • Configured VSCode and Cursor editor settings for consistent formatting
  • Updated biome.jsonc with file scope patterns and Ultracite core config
  • Enhanced CI workflow with concurrency controls and better documentation
  • Applied formatting fixes: quote style, semicolons, import ordering, trailing commas, EOF newlines
  • Fixed email template placeholder links (#/ and /privacy-policy)

Critical Issue:

  • .husky/pre-commit has bun test before the shebang, which will cause the hook to fail on execution

Confidence Score: 2/5

  • This PR has a critical bug that breaks git pre-commit hooks
  • The pre-commit hook has bun test before the shebang line, making it syntactically invalid and preventing commits. This must be fixed before merging. All other changes are safe formatting updates.
  • .husky/pre-commit requires immediate attention - the shebang must be on line 1

Important Files Changed

Filename Overview
.husky/pre-commit Pre-commit hook with critical bug: bun test on line 1 executes before shebang, will fail
.vscode/settings.json Configured Biome as default formatter with format-on-save for all file types
biome.jsonc Added Ultracite core config and file includes pattern to scope linting
package.json Updated to Ultracite 7.0.4, added husky, changed lint commands to use Ultracite CLI
.github/workflows/ci.yml Added concurrency controls, improved comments, renamed job to 'validate'
src/components/emails/verify-email.tsx Fixed placeholder hrefs: changed '#' to '/' and '/privacy-policy'

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Git as Git
    participant Husky as Husky Pre-commit
    participant Ultra as Ultracite Fix
    participant CI as GitHub Actions
    
    Dev->>Git: git commit
    Git->>Husky: Trigger pre-commit hook
    Husky->>Husky: Run bun test
    Husky->>Git: Check staged files
    alt Has staged files
        Husky->>Git: Stash unstaged changes
        Husky->>Ultra: bun x ultracite fix
        Ultra->>Ultra: Format staged files
        Ultra-->>Husky: Formatting complete
        Husky->>Git: Re-stage formatted files
        Husky->>Git: Restore unstaged changes
    end
    Husky-->>Git: Hook complete
    Git-->>Dev: Commit created
    
    Dev->>Git: git push
    Git->>CI: Trigger workflow
    CI->>CI: Install dependencies
    CI->>Ultra: bun lint (ultracite check)
    CI->>CI: bun typecheck (tsc)
    CI->>CI: bun test (vitest)
    CI-->>Dev: Build status
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

22 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment on lines 1 to 3
bun test

#!/bin/sh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: bun test on line 1 will execute before the shebang on line 3, causing the hook to fail. The shebang must be the first line.

Suggested change
bun test
#!/bin/sh
#!/bin/sh
bun test
Prompt To Fix With AI
This is a comment left during a code review.
Path: .husky/pre-commit
Line: 1:3

Comment:
**logic:** `bun test` on line 1 will execute before the shebang on line 3, causing the hook to fail. The shebang must be the first line.

```suggestion
#!/bin/sh
bun test

```

How can I resolve this? If you propose a fix, please make it concise.

Update .husky/pre-commit to place the shebang only once and ensure the
hook runs `bun test`. Remove the duplicate shebang line and keep the
`set -e` guard so the hook exits on any error. This cleans up the
pre-commit script, prevents a broken script header, and ensures the
test runner runs reliably before commits.
@kegren kegren merged commit bfd4e9a into main Jan 1, 2026
1 check passed
@kegren kegren deleted the chore-configure-editor-update-deps branch January 1, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant